Closed bashi closed 3 years ago
@jeffposnick PTAL when you have time?
Thank you very much for submitting this! I tried it out with a locally generated key and certificate, and things appeared to work fine with Chrome 93.
However, @vasilvv was the one who wrote the original server code, and I would feel best about letting them weigh in before merging this, just in case there are any other changes that need to be made. I'll reach out to @vasilvv directly via email as well, as I'm not sure if they check their GitHub notifications.
Merging after consultation with some members of the team.
@bashi Can you kindly update GoogleChrome samples WebTransport
code concurrent with Chromium source code updates and the updates made to WPT test server? As it stands the current code does not work using aioquic.
@yutakahirano FYI
Are you talking about https://web.dev/webtransport?
Oops, I was confused, sorry. Yes, we should update https://github.com/GoogleChrome/samples/tree/gh-pages/webtransport.
That too. Basically wherever documentation and codc is exposed. WPT banned me so I cannot contribute there. I have issues open in aioquic repository.
Google Chrome samples uses aioquic, so I expect Chrome authors to be involved in fixing those issues. I gather there are many updates being made. All the more reason to keep the server code here updated. Just do them both at the same time and developers in the field won't be using outdated technology. This same pattern occurred when QuicTransport
was deprecated; abandoned code was still deployed.
The example test page (client.html) should work on Chrome 91+ with this update.