search

GoogleChrome / samples

A repo containing samples tied to new functionality in each release of Google Chrome.
https://www.chromestatus.com/samples
Apache License 2.0
5.77k stars 2.38k forks source link

[webtransport] remove unnecessary code #764

Closed jlaine closed 2 years ago

jlaine commented 2 years ago

aioquic 0.9.19 already contains all the necessary settings for WebTransport, so there is no reason to subclass H3Connection.

jlaine commented 2 years ago

@yutakahirano @bashi I suspect the WPT code can also be simplified in this manner

jeffposnick commented 2 years ago

If @yutakahirano or @bashi can give their 👍 from a technical point of view, I'm happy to get this merged.

bashi commented 2 years ago

LGTM, nice cleanup! I haven't tested locally though. I'll try to update wpt server when I have time (I'm a bit swamped these days)

yutakahirano commented 2 years ago

Thank you for the change!

bashi commented 2 years ago

I realized that we can't update aioquic to 0.9.19 in WPT tools for now since the latest aioquic requires Python 3.7+ but WPT tools need to support Python 3.6.

jlaine commented 2 years ago

I realized that we can't update aioquic to 0.9.19 in WPT tools for now since the latest aioquic requires Python 3.7+ but WPT tools need to support Python 3.6.

That's unfortunate, Python 3.6 reached end of life at the end of 2021, it's no longer maintained. That's the reason I dropped support for Python 3.6 in aioquic and all my projects.

aboba commented 2 years ago

Question: The sample WebTransport client (https://github.com/googlechrome/samples/tree/gh-pages/webtransport) no longer seems to work with the latest WebTransport server. Has something changed?

bashi commented 2 years ago

Looks like it's working on my local environment. Could you force-reload then try again? Are there any errors in the DevTools console?