GoogleChrome / web-vitals-extension

A Chrome extension to measure essential metrics for a healthy site
https://chrome.google.com/webstore/detail/web-vitals/ahfhijdlegdabablpippeagghigmibma?hl=en
Apache License 2.0
2.35k stars 105 forks source link

Adjust the INP duration threshold #103

Closed rviscomi closed 1 year ago

rviscomi commented 2 years ago
image

INP currently shows as "waiting for input" even after interacting with the page, if the interaction latency is sufficiently small. As a result, we show data for FID, but not INP. This might throw people off, so look into lowering the reporting threshold for INP events in web-vitals.js.

We could lower the default threshold or let developers choose a threshold in the extension options to balance reporting with performance.

cc @philipwalton @mmocny

mmocny commented 2 years ago

Makes sense to me.

Pasting a bit more context here from prior conversations:

There could be value to doing both of the above, the the latter seems easier, more valuable, and less risky.

So, filed https://github.com/GoogleChrome/web-vitals/issues/228

mmocny commented 2 years ago

https://github.com/GoogleChrome/web-vitals/issues/228 is fixed and so now first input now always counts as an INP score.

There's more follow-up there chrome-side to change the reporting of FID, but I think if we just update the web-vitals library this issue will get a lot better.

I did also benchmark PO (this issue) and found that the there is no measurable overhead that I could find... but even adding something like a console.log can change to affect perf, and saving state from callbacks can affect things link GC. All that said, probably having DevTools perf panel open is a much larger effect on perf itself than this extension :)

tunetheweb commented 1 year ago

Looks to be resolved.