Closed jeremyriverain closed 2 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thank you for working on this @jeremyriverain! Sorry for the delay. If you're still interested, could you sync to the latest version and resolve the merge conflicts? If not I'm happy to pick up any remaining work on this PR. It'd be great to complete the Manifest v3 migration soon, as I understand we're running out of time.
@rviscomi sure i can work on it. It would be a pleasure to contribute.
Just give me a few days to find a moment and understand the changes to the repository since the last time.
I rebased this branch on the master branch. There were only minor conflicts in the manifest.json
file.
It seems that the extension works as before. That said, as I'm not the maintainer of the repo, I can't be sure.
Can you look at this work and tell me what you think please ? Is there anything I can do ?
Thank you @jeremyriverain! I've tested your branch locally and the extension appears to be working correctly. I'll go through the code more closely and leave any feedback.
@rviscomi thanks for reviewing my code. I applied your suggestions in this commit https://github.com/GoogleChrome/web-vitals-extension/pull/87/commits/f39bac4bd70c112fb79028d2b45996684107c67f
Woohoo thanks @jeremyriverain! I changed the destination branch from master
to a new one named manifest-v3
. We just released v1.1.1 to the store yesterday, and I'm anticipating that we may need to push some higher priority bug fixes in the coming weeks. Decoupling these changes from master
lets us publish bug fixes without risking more issues caused by the v3 migration.
Hello,
In order to better understand the implications of the new manifest V3, I made the effort to migrate from version 2 to version 3. Perhaps this work is a bit premature, given the recent publication of the new manifest. Anyway, I post here the result of my work, in case you are interested in some parts.
Regards. Jérémy Riverain