Closed tunetheweb closed 5 months ago
@tunetheweb I made a few tweaks to the code that I thought make things a bit clearer. Let me know if you have any issues with these changes, otherwise feel free to merge.
@philipwalton , I'll see your one array and raise you some more :-)
I also added a unit test GitHub action.
~I tried the e2e test but couldn't get it working. Even restricting it to Chrome required a number of extra options (args: ['headless', 'disable-gpu', 'remote-debugging-pipe'],
) and still fails CLS tests (though the others pass). Let's leave for now and might revisit later. Apparently it can be a bit flakey anyway, plus our tests are a little flakey themselves, so maybe not a good fit for CI.~
@philipwalton happy to merge? Or wanna have one last look after latest changes?
Actually I got the E2E tests working too. With one question.
Improved version of #286
Changes:
npm run test:e2e -- --browser=chrome --metric=TTFB
for example to limit tests to a particular browser and/or metric.it.only
's,depends.only
's, orbrowser.debug
's accidentally left around while testing.