Closed devjiwonchoi closed 2 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
@philipwalton Sorry to ping you, this issue is a blocker of upgrading TypeScript version, would love your review for it. 🙏
This is added in v4.2.1
, let me know if you're still seeing issues after upgrading.
The type of
LargestContentfulPaint
conflicts with the new TypeScript@5.5.2, which throws an error:The type has
readonly
which requires our type to be identical as well. The TypeScript:Fixes #498