search

GoogleChrome / web-vitals

Essential metrics for a healthy site.
https://web.dev/vitals
Apache License 2.0
7.55k stars 414 forks source link

TypeScript 5.5 compatibility #498

Closed SimenB closed 3 months ago

SimenB commented 3 months ago 
node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14706:14 - error TS2687: All declarations of 'element' must have identical modifiers.

14706     readonly element: Element | null;
                   ~~~~~~~

node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14708:14 - error TS2687: All declarations of 'id' must have identical modifiers.

14708     readonly id: string;
                   ~~

node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14710:14 - error TS2687: All declarations of 'loadTime' must have identical modifiers.

14710     readonly loadTime: DOMHighResTimeStamp;
                   ~~~~~~~~

node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14712:14 - error TS2687: All declarations of 'renderTime' must have identical modifiers.

14712     readonly renderTime: DOMHighResTimeStamp;
                   ~~~~~~~~~~

node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14714:14 - error TS2687: All declarations of 'size' must have identical modifiers.

14714     readonly size: number;
                   ~~~~

node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14716:14 - error TS2687: All declarations of 'url' must have identical modifiers.

14716     readonly url: string;
                   ~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:43:9 - error TS2687: All declarations of 'renderTime' must have identical modifiers.

43         renderTime: DOMHighResTimeStamp;
           ~~~~~~~~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:44:9 - error TS2687: All declarations of 'loadTime' must have identical modifiers.

44         loadTime: DOMHighResTimeStamp;
           ~~~~~~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:45:9 - error TS2687: All declarations of 'size' must have identical modifiers.

45         size: number;
           ~~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:46:9 - error TS2687: All declarations of 'id' must have identical modifiers.

46         id: string;
           ~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:47:9 - error TS2687: All declarations of 'url' must have identical modifiers.

47         url: string;
           ~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:48:9 - error TS2687: All declarations of 'element' must have identical modifiers.

48         element?: Element;
           ~~~~~~~

node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:48:9 - error TS2717: Subsequent property declarations must have the same type.  Property 'element' must be of type 'Element | null', but here has type 'Element | undefined'.

48         element?: Element;
           ~~~~~~~

  node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14706:14
    14706     readonly element: Element | null;
                       ~~~~~~~
    'element' was also declared here.

Found 13 errors in 2 files.

Errors  Files
     6  node_modules/.pnpm/typescript@5.5.2/node_modules/typescript/lib/lib.dom.d.ts:14706
     7  node_modules/.pnpm/web-vitals@4.2.0/node_modules/web-vitals/dist/modules/types.d.ts:43

CodeSandbox link

Run npm run build in the terminal to see the error

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#libdts-changes

Linked PR lists "new performance type LargestContentfulPaint", which seems like the obvious candidate