search

GoogleChrome / web-vitals

Essential metrics for a healthy site.
https://web.dev/vitals
Apache License 2.0
7.47k stars 410 forks source link

Use fancy md notes #503

Closed rviscomi closed 1 month ago

rviscomi commented 1 month ago

This makes use of GitHub's fancy note/warning UI in markdown, which helps them stand out. Use the rich diff to see the effects.

Also converted a few places that talk about FID deprecation to use a more noticeable "Caution" UI.

rviscomi commented 1 month ago

Looks like it was caused by a multi-line note. Prettier fixed it by adding the blockquote syntax, although we could have also just made it a single-line note. Went with the prettier fix and the linter seems to be happy now.

philipwalton commented 1 month ago

Looks like it was caused by a multi-line note. Prettier fixed it by adding the blockquote syntax, although we could have also just made it a single-line note. Went with the prettier fix and the linter seems to be happy now.

Ahh, just saw this comment, my preference would be to make it a single line so it's consistent with the other notes.