search

GoogleChrome / webdev-infra

Apache License 2.0
37 stars 28 forks source link

Make browser name show up nicer in RSS #69

Closed tomayac closed 1 year ago

tomayac commented 1 year ago

I hope this fixes the RSS feed issue highlighted below:

Screenshot 2023-03-30 at 11 36 22

The idea is to have a friendly name that reads "Chrome" instead of "chrome".

tunetheweb commented 1 year ago

We already hardcode the browsers here:

const BROWSERS = ['chrome', 'firefox', 'edge', 'safari'];

So wouldn't it be better (and more future proof) to hardcode the friendly name too? You know, in case Internet Explorer ever comes back 😁 Or we want to include Samsung Internet in future.

tomayac commented 1 year ago

Definitely an option to reverse the logic. Lemme do that.

tomayac commented 1 year ago

PTAL. Sorry, this is untested, I’m editing from a phone while on a train. 🫣

tunetheweb commented 1 year ago

I was thinking more like this: https://github.com/GoogleChrome/webdev-infra/pull/70

tomayac commented 1 year ago

Superseded by #70.