search

GoogleChrome / webdev-infra

Apache License 2.0
37 stars 28 forks source link

a11y: added title to browser icon, support icon and source #74

Closed ShayPunter closed 1 year ago

ShayPunter commented 1 year ago

Implements a11y support for {% BrowserCompat %} table

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tunetheweb commented 1 year ago

title is not exposed in the accessibility tree for <span> elements so this won't improve a11y. And in fact title is generally seen as poor for a11y and to be avoided.

For the Sources link there is already accessible text.

And for the icons themselves, there already is visually hidden text that is exposed to AT

So, can you explain more about the intent of this PR?