search

GoogleChrome / webdev-infra

Apache License 2.0
40 stars 28 forks source link

Consolidate aside implementation & add tip type #79

Open ShayPunter opened 1 year ago

ShayPunter commented 1 year ago

Fixes #77

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

matthiasrohmer commented 1 year ago

Also please have another look at the icons. The GitHub file overview gives a good idea of what's worth to double check: highlighter and ink-highlighter are the same, the same for lightbulb and lightbulb-outline, graph looks weirdly vertically aligned, update has a weird view box.

matthiasrohmer commented 1 year ago

One last note: please make sure to sign the CLA.