GoogleChrome / webdev-infra

Apache License 2.0
40 stars 28 forks source link

Fix i18n directory not resolving properly when parentheses are used #82

Closed ShayPunter closed 1 year ago

ShayPunter commented 1 year ago

Fixes #66

It would appear that the issue does not relate to the use of spaces, but rather special characters. This also seems to only effect parentheses, and no other special characters as tested (tested with the following: <> [] {} -- == ** ^^).

How to test

  1. Clone webdev-infra and checkout this branch '77_i18n_util_fails_if_run_from_path_with_spaces'
  2. Create a local folder which contains parentheses in (e.g. /Shay/programming/Shay (test)/)
  3. Clone developer.chrome.com or web.dev to the folder
  4. Setup a symlink to the appropriate place
  5. run 'npm ci'
  6. run 'npm run dev'
  7. successful build should happen
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.