search

GoogleChrome / webstatus.dev

A tool to monitor and track the status of all Web Platform features across dimensions that are related to availability and implementation quality across browsers, and adoption by web developers.
https://webstatus.dev
Apache License 2.0
103 stars 8 forks source link

Modify YAML to support snapshot usage data #846

Closed DanielRyanSmith closed 2 weeks ago

DanielRyanSmith commented 2 weeks ago

Fixes #780

Modifies the schema to accommodate usage data for multiple browsers, with Chromium data to start.

DanielRyanSmith commented 2 weeks ago

I'm hoping I understood the desired result correctly, but please correct me if not!

jcscottiii commented 2 weeks ago

You will also need to modify the backend a little bit. The openapi changes will change the generated go code. Potentially the same thing for the frontend.

DanielRyanSmith commented 2 weeks ago

Sorry, I'm confused at what also needs to be changed here, since we're not using this property yet in the code base - from what I can tell, the files that generate the models are ignored and not version controlled, is that correct? Should I make additional change to utilize this updated property, or is that best for a subsequent PR?

Edit: I did have an error in the YAML change when you looked at this @jcscottiii, which was causing the CI to fail, but that should be fixed now

jcscottiii commented 2 weeks ago

Edit: I did have an error in the YAML change when you looked at this @jcscottiii, which was causing the CI to fail, but that should be fixed now

You're right. I saw there was an error but I did not look at the error. Normally, when you add a new field, you will need to adjust the backend structs to prevent some lint errors (what I thought the error was). But since the usage field was already there, we don't have that problem. This is good to go!