webpack v5 compatibility

GoogleChrome / workbox

📦 Workbox: JavaScript libraries for Progressive Web Apps

https://developers.google.com/web/tools/workbox/

MIT License

12.35k stars 814 forks source link

webpack v5 compatibility #2630

Closed chenxsan closed 4 years ago

chenxsan commented 4 years ago

Library Affected:

workbox-webpack-plugin

Browser & Platform:

None

Issue or Feature Request Description:

webpack 5 exposes webpack-sources via webpack.sources, and it's advised to use it instead of require('webpack-sources'), if you agree to do it, I can submit a pull request.

jeffposnick commented 4 years ago

There's a number of non-trivial changes that are needed for webpack v5 compatibility. (C.f. https://github.com/webpack/webpack/issues/11425)

I'm working on implemented all of those changes in the Workbox v6 branch, hopefully in time for the next Workbox pre-release.

chaffeqa commented 4 years ago

great to hear! we just moved to webpack 5 and had to remove workbox since it was causing the build to error out.

chaffeqa commented 4 years ago

the WP5 branch is looking really good! would love to give it a test drive for you!

jeffposnick commented 4 years ago

This is now live as part of the v6.0.0-alpha.3 release: https://github.com/GoogleChrome/workbox/releases/tag/v6.0.0-alpha.3