search

GoogleChrome / workbox

📦 Workbox: JavaScript libraries for Progressive Web Apps
https://developers.google.com/web/tools/workbox/
MIT License
12.34k stars 814 forks source link

Source map support for injectManifest makes incorrect assumptions #3233

Open steverep opened 1 year ago

steverep commented 1 year ago

Library Affected: workbox-build

Browser & Platform: n/a

Issue or Feature Request Description: It looks like source map support was added for the Webpack plugin in #2239 when injecting the manifest. However, there is no such support for the injectManifest method in the workbox-build package. It would be helpful if the same code could be applied there, i.e. if a source map exists for swSrc then write an adjusted one for swDest.

steverep commented 1 year ago

Looks like support exists but there are bugs in the implementation. I commented on the original PR.

For my case, it is appearing as if there is no support because the original source map is just being overwritten rather than writing a new one with the new filename and updating the URL.

tomayac commented 6 months ago

Hi there,

Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:

Thanks, and we hope for your understanding! The Workbox team

steverep commented 6 months ago

@tomayac sorry I don't understand the closing issues move at all. I don't think an "if I don't see it it doesn't exist" strategy works in software development (or anywhere in life for that matter). The code hadn't been touched in almost a year, so why would issues filed within that time be stale or otherwise worthy of closing without actual triage?

This problem exists and there's a PR to fix it, so am I just supposed to open a new one just to be in 2024?

tomayac commented 6 months ago

Sorry, looks like this should not have been closed since it has an active PR. Reopening.

steverep commented 5 months ago

Sorry, looks like this should not have been closed since it has an active PR. Reopening.

Thank you. I updated the PR with the recent changes so the test workflow can be run.