search

GoogleChromeLabs / ProjectVisBug

FireBug for designers › Edit any webpage, in any state https://a.nerdy.dev/gimme-visbug
https://visbug.web.app
Apache License 2.0
5.42k stars 285 forks source link

Download images plugin Issue#480 #491

Closed aashu0148 closed 3 years ago

aashu0148 commented 3 years ago

All the downloading images will have a name

argyleink commented 3 years ago

closing since the work was merged in #492

aashu0148 commented 3 years ago

closing since the work was merged in #492

Oh :(

Is there any other issue suitable for me. Any other issue i can contribute to ?

argyleink commented 3 years ago

yep definitely! what kind of stuff do you want to try next? add features, bug fix, learn more about X? i can help guide you to something new?

you can also see the current state of the plugin ux at the branch here https://github.com/GoogleChromeLabs/ProjectVisBug/pull/481, and it's not done yet! maybe you want to help finish it off? it's currently stuck at failing about 30% of images when run on real sites. You'll need to install the extension locally and run it on a webpage like css-tricks, to get the more "real world" set of urls. it's very very close! but when you run it, there's a few visual images that dont download, and it's due to either bad fetch urls, or bad names we try to write to disk. still trying to iron out all the frayed edges so this thing is pretty dependable and smooth.

thanks for all the help so far!

aashu0148 commented 3 years ago

hey @argyleink sorry for late reply actually i got a project to do... so i was busy in that.

ya some images are not downloading i guess the reason could be the images from local folder. like the URL can be "./assets/images/photo.jpeg" now in this case we can't get that image.

argyleink commented 3 years ago

totally. there's a few cases we can't handle, totally cool with that, but it feels like too many are failing. especially since i can go find the url and open it in my browser. sometimes it's the name it tries to create on file is invalid, which makes sense, that logic is getting complex.

i figure we can widdle away at the few easy wins, and then merge it? i'd like it to be a bit more reliable. thoughts?

aashu0148 commented 3 years ago

totally. there's a few cases we can't handle, totally cool with that, but it feels like too many are failing. especially since i can go find the url and open it in my browser. sometimes it's the name it tries to create on file is invalid, which makes sense, that logic is getting complex.

i figure we can widdle away at the few easy wins, and then merge it? i'd like it to be a bit more reliable. thoughts?

ya if it is failing too many of images then its not good at all. can you please provide those urls which are not working... i guess there can be some issue with the name.

argyleink commented 3 years ago

I havent grabbed all the URLs yet, thats def a great next task. Aggregate them and figure out the problems.

I also think it might be the filename we create, like the file/url fetches 200, but we try to create a filename that isnt valid. I think it's a bit of both still left to do!?