GoogleChromeLabs / ProjectVisBug

FireBug for designers › Edit any webpage, in any state https://a.nerdy.dev/gimme-visbug
https://visbug.web.app
Apache License 2.0
5.41k stars 284 forks source link

Suggestions for improvement #535

Closed chris-kruining closed 2 years ago

chris-kruining commented 2 years ago

I've been working on a visual editor on my own for a CMS I am making and some tips I learned from that:

just a few lessons I learned from some toe-stubbing. feel free to do with this whatever you want 😊

argyleink commented 2 years ago

visbug already ships constructible stylesheets in it's web components! uses a polyfill for browsers that don't support it. agree it's been very nice to work with.

can you link to you're 2d canvas implementation? perf on visbug is very good, curious what you ran into that was slow and what your overlays look and interact like.

chris-kruining commented 2 years ago

visbug already ships constructible stylesheets in it's web components! uses a polyfill for browsers that don't support it. agree it's been very nice to work with.

ikr, so lovely, can't wait for full support in all browsers

can you link to you're 2d canvas implementation? perf on visbug is very good, curious what you ran into that was slow and what your overlays look and interact like.

This is gonna take me a little while, my implementation is closed source for my job, so I'd need to find a way to extract that specific bit. but in essence the canvas has pointer-events: none; and I have a load of pointer events set up which trigger the rendering of stuff for the canvas. I do have an unlisted yt vid demo-ing a WIP, but it may contain sensitive data, so I am willing to share it in a pm, but not in a public comment