Closed mayank99 closed 2 years ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
everyone will get the update within the hour! thank you for this, it's raddddd!
thanks for the lovely comments and for accepting the contribution 💜
the process was mostly smooth, but i couldn't get dev:extension
to work on windows (it uses cp
) so i only tested in the local dev environment
i did notice some transform drift when resizing from the top? i think it's acceptable given the illusion working so well. the handles don't drift is what i mean, and i think that was a good choice and this is an ok side effect.
yeah... i noticed that this issue happens only on some elements but not others. i could not figure out why, it might have something to do with the layout?
i couldn't get dev:extension to work on windows (it uses cp) so i only tested in the local dev environment
i was wondering if you'd tried loading the extension unpacked..! i'm sad that cp
prevented that, sorry about that! there's certainly some infra updates that could be done in the codebase to smooth out cross platform and cross IDE dev. need to block out some maintenance time. also need to update to manifest v3. thanks for letting me know tho! want to log a bug about it?
p.s. looks like auto publishing github action stopped working, just manually uploaded
Closes #17
visbug-handles
to the newvisbug-handle
element.handle-css
andHandleStyles
and added new singular ones for the elementplacement
. e.g.<visbug-handle placement="top-end">
.Order of events is as follows:
on_element_resize_start
on_element_resize_move
on_element_resize_end