Closed mingodad closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Are we likely to see other problems with other older browsers like FF and IE?
This should probably be handled in the Sass so that auto prefixer can do this work for us.
I'm also not sure that 'apple-mobile-web-app-capable' is needed and will add bad UX when launched from homescreen since no consideration has been given to back button removal.
I'm not sure if gauntface understand the problem of accessing the "transform" attribute through javascript when he suggest to handle it with Sass ?
Sorry I didn't explain myself well at all.
My proposal was to change the current approach to:
1.) Add a CSS class name to the nav drawer to toggle open / closed 2.) Move the transform into Sass based on this new CSS class.
It seems to be a good idea because the same (if prefixed) rule would be used.
Another PR has been merged to address this.
If the problem still exists, please raise an issue.
After debugging and experimenting different approaches this hack made the navigation menu work on iOS 8. I belleve it'll not cause any problem on other browsers, tested on chrome/firefox/safari/iOS 8.