search

GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.37k stars 82 forks source link

code refactoring #119

Open phewphewb opened 2 years ago

phewphewb commented 2 years ago

This PR aims to improve code readability. No strong feelings attached. Feel free to close the PR if you think this is not necessary.

tomayac commented 2 years ago

Please move on with the suggested improvements and let me know when you have agreed on a design. Thanks for the PR and discussion so far already.

phewphewb commented 2 years ago

@tomayac, @tshemsedinov, I am working on updating this file if this one is fine

tomayac commented 2 years ago

@tomayac, @tshemsedinov, I working on updating this file if this one is fine

Thanks, please do. We can turn this into a big refactoring PR.

phewphewb commented 2 years ago

@tshemsedinov

phewphewb commented 2 years ago

@tshemsedinov, kind reminder for your code review please

tomayac commented 1 year ago

Is anyone still interested in this? The code as is seems to be pretty stable, so maybe we can close this?

phewphewb commented 1 year ago

@tomayac, the refactoring is done, it just needs a proper code review. Feel free to close the PR if you do not think this code refactoring is beneficial for the library. The only purpose of this PR was to improve code readability for any possible further feature development in the library. I am willing to put more work in it if needed.

tomayac commented 1 year ago

@tomayac, the refactoring is done, it just needs a proper code review. Feel free to close the PR if you do not think this code refactoring is beneficial for the library. The only purpose of this PR was to improve code readability for any possible further feature development in the library. I am willing to put more work in it if needed.

Sounds good to me. Before I start my review, any changes planned for directory-open.mjs?

phewphewb commented 1 year ago

no changes planned for directory-open.mjs