GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.38k stars 84 forks source link

fix build on windows #13

Closed dwelle closed 4 years ago

dwelle commented 4 years ago

npx ./build.sh can't be run on windows. Not sure what npx does, but I assume it just falls back to executing ./build.sh which fails on Windows in case it's run from Command prompt (or the like), even when bash/sh is installed.

Thus I'm reverting to running bash explicitly. This obviously requires it to be installed, but the build.sh script would fail if it weren't ITFP.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

dwelle commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tomayac commented 4 years ago

npx ./build.sh can't be run on windows. Not sure what npx does, but I assume it just falls back to executing ./build.sh which fails on Windows in case it's run from Command prompt (or the like), even when bash/sh is installed.

Thus I'm reverting to running bash explicitly. This obviously requires it to be installed, but the build.sh script would fail if it weren't ITFP.

Thanks, good catch. I use shx throughout, but forgot to make the bash script cross-platform. Thanks!