Closed dwelle closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
npx ./build.sh
can't be run on windows. Not sure whatnpx
does, but I assume it just falls back to executing./build.sh
which fails on Windows in case it's run from Command prompt (or the like), even whenbash
/sh
is installed.Thus I'm reverting to running
bash
explicitly. This obviously requires it to be installed, but thebuild.sh
script would fail if it weren't ITFP.
Thanks, good catch. I use shx throughout, but forgot to make the bash script cross-platform. Thanks!
npx ./build.sh
can't be run on windows. Not sure whatnpx
does, but I assume it just falls back to executing./build.sh
which fails on Windows in case it's run from Command prompt (or the like), even whenbash
/sh
is installed.Thus I'm reverting to running
bash
explicitly. This obviously requires it to be installed, but thebuild.sh
script would fail if it weren't ITFP.