GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.37k stars 82 forks source link

Adds exported types to moduleResolution:node16 #137

Closed dmihalcik-virtru closed 1 year ago

dmihalcik-virtru commented 1 year ago

This will let users get type information when compiling ESM projects with node module settings in later versions of tsc and node 18+

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dmihalcik-virtru commented 1 year ago

Notably, without this line I'll get the following error when trying to build my project (node 18, tsconfig with module: CommonJS, moduleResolution: node16, package.json with type: module), so maybe not a common configuration but what I'm doing :-0

image