Closed kbariotis closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
hey @kbariotis , i created another PR for the same issue, i even tested it on excalidraw (inside iframe), i am just checking if we are within a third part environment and returning false in supported function. this will not need any change in excalidraw code base i guess.
also if you feel my approach can work, can you please close this PR and maybe let my PR get merged, as it is kindoff a small dream for a college student like to get a PR merged in some well well used repo :)
I’ll have a look on Monday (since this is a work project) and merge this. Thanks for the PR.
Export the supported function to be used when there is the need to check whether the FS Access API is supported.
https://github.com/excalidraw/excalidraw/pull/3047