GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.38k stars 84 forks source link

checking if app is running in third- or first-party environment #40

Closed nikhilbghodke closed 3 years ago

nikhilbghodke commented 3 years ago

hey @tomayac , i saw issue filled on the repo, https://github.com/GoogleChromeLabs/browser-fs-access/issues/38, i tired to fix this my adding a small check in supported function. i even tested the solution by embedding the demo project in the repo inside an iframe, it works well. i have a dependency of this fix , as browser-fs-access is been used by excalidraw board, which we want to use inside iframe in our application, so if you could review and publish module to npm, i would be really helpful of you !

Thanking in anticipation

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nikhilbghodke commented 3 years ago

@googlebot I signed it!

tomayac commented 3 years ago

I’ll have a look on Monday (since this is a work project) and merge this. Thanks for the PR.

sunitapt commented 3 years ago

hey @tomayac, even I am facing a similar issue like @nikhilbghodke on another application that uses this module, glad to find this PR at right time! I liked his approach, tried it out locally, and seems to work fine.

It would be awesome if you could merge this PR asap.