Closed nikhilbghodke closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
I’ll have a look on Monday (since this is a work project) and merge this. Thanks for the PR.
hey @tomayac, even I am facing a similar issue like @nikhilbghodke on another application that uses this module, glad to find this PR at right time! I liked his approach, tried it out locally, and seems to work fine.
It would be awesome if you could merge this PR asap.
hey @tomayac , i saw issue filled on the repo, https://github.com/GoogleChromeLabs/browser-fs-access/issues/38, i tired to fix this my adding a small check in supported function. i even tested the solution by embedding the demo project in the repo inside an iframe, it works well. i have a dependency of this fix , as
browser-fs-access
is been used byexcalidraw
board, which we want to use inside iframe in our application, so if you could review and publish module to npm, i would be really helpful of you !Thanking in anticipation