Closed simon-lammes closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thank you very much!
Previously, the functions
fileOpen
andfileSave
used an undefined generic type ofO
. This caused TypeScript compiler issues in some environments. (details in commit discussion)If I understand the types correctly, the generic type O is not needed. We just want TypeScript to know that options is either of the array type
[FirstFileSaveOptions, ...CoreFileOptions[]]
or of the object typeFirstFileSaveOptions
.