GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.38k stars 84 forks source link

fix: TypeScript declarations #65

Closed simon-lammes closed 3 years ago

simon-lammes commented 3 years ago

Previously, the functions fileOpen and fileSave used an undefined generic type of O. This caused TypeScript compiler issues in some environments. (details in commit discussion)

If I understand the types correctly, the generic type O is not needed. We just want TypeScript to know that options is either of the array type [FirstFileSaveOptions, ...CoreFileOptions[]] or of the object type FirstFileSaveOptions.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

simon-lammes commented 3 years ago

@googlebot I signed it!

tomayac commented 3 years ago

Thank you very much!