GoogleChromeLabs / browser-fs-access

File System Access API with legacy fallback in the browser
https://googlechromelabs.github.io/browser-fs-access/demo/
Apache License 2.0
1.38k stars 84 forks source link

Bundle to esm and cjs #83

Closed steveruizok closed 2 years ago

steveruizok commented 2 years ago

This PR changes the build process so that the library outputs a format in both commonjs and esmodules.

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

tomayac commented 2 years ago

@steveruizok In order to land this, could I ask you to make the bot 🤖 happy?

steveruizok commented 2 years ago

Done! (I think)

tomayac commented 2 years ago

@steveruizok, once you have done the work the bot asks you to do, you need to respond here with "@googlebot I signed it!". (Sorry for the hassle.)

tomayac commented 2 years ago

Oh, looks like as long as anyone responds with the magic phrase the bot is happy (if you have signed the thing). So ignore. Thank you!