GoogleChromeLabs / bubblewrap

Bubblewrap is a Command Line Interface (CLI) that helps developers to create a Project for an Android application that launches an existing Progressive Web App (PWAs) using a Trusted Web Activity.
Apache License 2.0
2.4k stars 162 forks source link

App is freezing or crashing after some time #130

Closed nimit95 closed 4 years ago

nimit95 commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

andreban commented 4 years ago

Can you add more information to the issue, please? Is this a problem with the CLI interface or Without details on what is happening, device, browser version, etc, it is impossible to solve any issue.

nimit95 commented 4 years ago

Oh, sorry, I am talking about the android app. I tried in my phone(Oneplus 5t and android 9) and in my friends Samsung galaxy s9. If the app is on the screen for like 3 min. It would either freeze or crash. I couldn't get the logs but should be easy to reproduce.

nimit95 commented 4 years ago

Also a great CLI tool overall :). I initially put my JDK path wrong, it got saved in a llama config file. It took me a while to figure the config file and its location, as that file overrides ENV variables and twa manifest file. I will create a PR in the readme or you would like me to create a fix in the code?

andreban commented 4 years ago

Thanks for the update. Since the application freezes after ~3 minutes, my guess is that it is freezing while the Web app is open. Is that correct? If you open the same app in the browser, does it freeze?

Thanks for the feedback on the config. Contributions are always greatly appreciated, so if you want to send a PR for the readme or improving how the CLI works, you are welcome. I'd ask you to create an issue first, so we can discuss the problem and the solution. How does that sound?

nimit95 commented 4 years ago

Nope, when I open in the browser it doesn't freeze. It is very specific to the app created by CLI. Also, another observation I made was that if I switch between apps, CLI generated app and any other app. There are increased chances of a crash with a CLI app. And that doesn't happen with chrome on my mobile.

Cool will create a seprate issue for the same. Thanks.

andreban commented 4 years ago

The app generated by the CLI is a wrapper that just launches a Trusted Web Activity, which is basically Chrome without an UI. I'd expect issues to happen when launching the app, but freezing after it's open is a bit odd.

Nevertheless, since it's freezing inside the Trusted Web Activity, this looks more like a Chrome issue than a Bubblewrap one. Do you mind filing the bug on Chromium using this template, so we have it filed in the right place?

andreban commented 4 years ago

Closing this, as this seems unrelated to Bubblewrap. Please, file the issue on Chromium with the template provided in the previous message if the issue persists.