search

GoogleChromeLabs / bubblewrap

Bubblewrap is a Command Line Interface (CLI) that helps developers to create a Project for an Android application that launches an existing Progressive Web App (PWAs) using a Trusted Web Activity.
Apache License 2.0
2.29k stars 152 forks source link

Add themeColorDark aka colorPrimaryDark aka STATUS_BAR_COLOR_DARK #816

Closed khmyznikov closed 11 months ago

khmyznikov commented 12 months ago

Added customtabs.trusted.STATUS_BAR_COLOR_DARK.

Fixes #802

google-cla[bot] commented 12 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

khmyznikov commented 11 months ago

@SayedElabady Could you please create a new release that includes this change. I'm planning to add integration of the new field to PWABuilder.

GCSBOSS commented 11 months ago

@SayedElabady need this in release. I will add integration of new field with PWABuilder.

Waiting to know when this gets releases on PWABuilder /o/

andreban commented 11 months ago

@khmyznikov @GCSBOSS This has been deployed on Bubblewrap 1.21.0