search

GoogleChromeLabs / buffer-backed-object

Buffer-backed objects in JavaScript.
https://npm.im/buffer-backed-object
Apache License 2.0
390 stars 14 forks source link

Add buffer's byteOffset to NestedArrayOfBufferBackedObjects byteOffset #35

Closed Thristhart closed 1 year ago

Thristhart commented 1 year ago

This fixes an issue with nested arrays, where the offset would not take into account the dataview's offset.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

surma commented 1 year ago

Hm, tests seems to be broken for me, but it looks good 😅

Will merge this PR and give this package a love tap. Thanks @Thristhart!