GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.31k stars 309 forks source link

Separate terminal window when packaged on windows #117

Open JarLob opened 5 years ago

JarLob commented 5 years ago

As I understand Carlo doesn't take the responsibility for packaging. But just to let you know current implementation of pkg on Windows gives bad UX experience, because a separate terminal window is launched additionally to Carlo window.

image

The only workaround I found requires to create an additional vbs file and launch the package through it.

Simran-B commented 5 years ago

Related issue for pkg: https://github.com/zeit/pkg/issues/520

Someone suggested to use this to modify the executable: https://github.com/s-h-a-d-o-w/create-nodew-exe It seems to modify a byte in the file to suppress the terminal (redirect stdout or is it really just a simple flag?).

Can you try it out and let us know the result? @JarLob