search

GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.31k stars 309 forks source link

Allow configuration of where the RPC content script is read from via rpcContentScriptDir #135

Open nessup opened 5 years ago

nessup commented 5 years ago

This allows the RPC content script to be arbitrary read from any directory, rather than the default __dirname + '../rpc/rpc.js. This is important in situations where node_modules may be inaccessible in certain situations, such as in production builds.

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.