GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.32k stars 309 forks source link

carlo app should not open all links #141

Open alexkozy opened 5 years ago

alexkozy commented 5 years ago

Steps:

  1. close all Chrome instances,
  2. run carlo app that uses stable.
  3. run open https://google.com from terminal.

Expected: link open in Chrome with default profile. Actual: carlo app gets window event and by default will open new window with its profile.

At the same time if I run the same carlo app twice, I expect window event in first app instance. I believe that something scary will happen if I open two different carlo apps - I have not checked it yet.

In ideal world I wish to have some Chrome flag, let's call it --carlo-app-id and then Chrome will uses current Chrome iff this id is equal otherwise it will try another running Chrome instance. Carlo will generates something random enough for each app and bright future will be here.