search

GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.32k stars 309 forks source link

carlo will not launch on win10 #148

Open mu-yu opened 5 years ago

mu-yu commented 5 years ago

Accoding to some bug/feature in puppeteer, carlo/puppeteer will not launch on win10 sometimes. see: https://github.com/GoogleChrome/puppeteer/issues/3186

here is how to fix I found: when launch puppeteer, add an option ignoreDefaultArgs: ['--disable-extensions'], to puppeteer.launch in this line https://github.com/GoogleChromeLabs/carlo/blob/master/lib/carlo.js#L619

ThomasMcGarry101 commented 5 years ago

Adding the option "ignoreDefaultArgs: ['--disable-extensions']," does not appear to resolve the problem. Is this issue being addressed or are there any other short term work around?

mu-yu commented 5 years ago

Adding the option "ignoreDefaultArgs: ['--disable-extensions']," does not appear to resolve the problem. Is this issue being addressed or are there any other short term work around?

The option shoud put into the source of carlo where carlo init the pptr, not the code of yours where init carlo.Carlo doesn't have this option at the moment.

see: https://github.com/GoogleChrome/puppeteer/issues/3186