fix(shortcuts): use event.key to get key

GoogleChromeLabs / carlo

Web rendering surface for Node applications

Apache License 2.0

9.32k stars 309 forks source link

fix(shortcuts): use event.key to get key #157

Closed alexkozy closed 5 years ago

alexkozy commented 5 years ago

As stated in [1] in French layout event.code returns KeyQ for letter A. It forces carlo app to exit on Ctrl + Shift + A instead of Q. Bug originally reported here: https://github.com/GoogleChromeLabs/ndb/issues/225

[1] https://hacks.mozilla.org/2017/03/internationalize-your-keyboard-controls/