GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.32k stars 309 forks source link

fix(launcher): add unused CHROME_PATH to the array of installed executables #162

Closed reminjp closed 2 years ago

reminjp commented 4 years ago

Although the error says

The environment variable CHROME_PATH must be set to executable of a build of Chromium version 54.0 or later.

CHROME_PATH is never added to installations.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

reminjp commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

reminjp commented 2 years ago

https://github.com/GoogleChromeLabs/carlo/issues/163#issuecomment-592238093