GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.31k stars 309 forks source link

rpc.md example hangs #63

Open vsemozhetbyt opened 5 years ago

vsemozhetbyt commented 5 years ago
  1. I've created 3 files described in rpc.md#example.
  2. I've replaced requiring with these lines:
    const { rpc } = require('carlo/rpc');
    const { rpc_process } = require('carlo/rpc');
  3. I've fixed this typo in family.js (see https://github.com/GoogleChromeLabs/carlo/pull/62):
    -    const ordinal = this.children_.length;
    +    const ordinal = this.children.length;
  4. I've run the main.js and, after this output, the script stuck with no errors or progress:
    Adding child #0
    Adding child #1

    Have I done something wrong?

pavelfeldman commented 5 years ago

Hm. This is what I get:

Adding child #0
Adding child #1
I am #0 and I have a sibling #1
I am #1 and I have a sibling #0
I am #1 and my sibling #0 is saying hello
I am #0 and my sibling #1 is saying hello
vsemozhetbyt commented 5 years ago

I've checked on Windows 7 x64 with Node.js 08.12.0, 10.13.0, 11.1.0, 12.0.0 nightly and v8-canary + carlo 0.9.15. All variations hang. Can anybody reproduce?

kraciasty commented 5 years ago

Same as @vsemozhetbyt

Adding child #0
Adding child #1

Script stuck