search

GoogleChromeLabs / carlo

Web rendering surface for Node applications
Apache License 2.0
9.31k stars 309 forks source link

Is `icon` option platform-restricted? #88

Open vsemozhetbyt opened 5 years ago

vsemozhetbyt commented 5 years ago

I've tried both the path and the Buffer variants with Canary on Windows 7 x64 (using an icon from an example folder), but only got the default icon in system taskbar and window titlebar. Does Canary on Windows support this feature?

ab35 commented 5 years ago

I confirm the issue on windows 10 x64 trying the photobooth example: the taskbar icon of the application is the regular canary icon instead of the custom icon.

But for stable chrome, the app icon shows up as expected, though first the regular chrome icon appears for one second and then changes into the app icon.

I'm wondering if there is a way to avoid the icon swapping though for good UX.

sidevesh commented 5 years ago

In my case it seems like the icon property has no effect at all, on opening the app, it first shows chrome icon (I am using stable on windows 10), then a grey globe and then the favicon of the opened web page. The icon I have assigned in launch config never shows up.

sidevesh commented 5 years ago

Even on linux (Elementary OS based on Ubuntu 18.04 LTS) the chrome icon shows up. Any updates on this thread ? @pavelfeldman