search

GoogleChromeLabs / chromeos_network_file_share

*** DEPRECATED *** SMB support is now built into Chrome OS since 71. See README for more info.
GNU General Public License v3.0
57 stars 30 forks source link

Failing first read on large files with Software caused connection abort #1

Closed illiminable closed 5 years ago

illiminable commented 8 years ago

This repro'd reliably on my home NAS from Pixel. 3 retries fail. Need to try and get wireshark dump.

illiminable commented 8 years ago

Also observed from ARM Asus Flip to my work NAS. 3 retries fail. But the work NAS is fine with the pixel.

illiminable commented 8 years ago

Sporadically see it with Pixel on work NAS too.

Maybe related https://bugzilla.samba.org/show_bug.cgi?id=11079 https://bugzilla.samba.org/show_bug.cgi?id=11173

These are fixed in Samba 4.1.18 and the port is based on 4.1.16. Going to try to upgrade same lib.

illiminable commented 8 years ago

Was able to easily upgrade to 4.1.22 but doesn't seem to fix it.

Next attempt is to attempt retry within the native layer - potentially reopening the file on this failure. Also will try reducing the buffer size since it seems to start breaking around 256k (and FSP requests in 512k chunks).

illiminable commented 8 years ago

Some users are still seeing this in their configuration.

dskaram commented 8 years ago

Need to ensure this also fixes

https://crbug.com/583113

illiminable commented 5 years ago

Since Chrome 71, SMB is now natively supported by Chrome OS and this Chrome extension/app is deprecated. The new implementation is an order magnitude or two faster and much more reliable.

On Chrome 71 or higher you can:

Open the files app Click the "three dot menu" in the top right Choose "Add New Service" Choose "SMB file share"

A dialog in settings will open (in 72 and later it's a standalone dialog). Enter your share information as before.

You can uninstall the chrome app as it will be deprecated in the near future.

If you have bugs with the new implementation you can open them at crbug.com under component "Platform>Apps>FileManager"