search

GoogleChromeLabs / chromeos_network_file_share

*** DEPRECATED *** SMB support is now built into Chrome OS since 71. See README for more info.
GNU General Public License v3.0
57 stars 30 forks source link

Investigate "got field but didn't request" messages #60

Closed illiminable closed 7 years ago

illiminable commented 7 years ago

Part of the optimization work in the previous release was to make the files app be specific which fields it wants during requests such as readDirectory. This is because on the samba/native side it's cheap to get all the filenames, but more expensive to get the metadata. The files app frequently requested data it never used so this allowed the plugin to know which data it really cared about for this request.

On the CrOS/files app side a check/log occurs if the plugin sends data it didn't request. Would could maybe consider removing this logging since it generally doesn't hurt to send extra information.

However at the time knowing that was there; the plugin filters metadata responses to remove the fields that weren't requested (this is most relevant when it got a cache hit). At some point since the last release this seems to have regressed and the logs get spammed with these messages.

Need to investigate if the app is not filtering correctly or if the files app is not checking correctly.

illiminable commented 7 years ago

Tagged performance because the load of this logging can be very very heavy.