GoogleChromeLabs / chromeos_network_file_share

*** DEPRECATED *** SMB support is now built into Chrome OS since 71. See README for more info.
GNU General Public License v3.0
57 stars 30 forks source link

Investigate a cancellation signal from the files app #64

Closed illiminable closed 5 years ago

illiminable commented 7 years ago

Investigate current working state.

1) Check if the plugin is correctly handling onAbortRequested. It almost certainly isn't propagating the failure to the native side which may be in a loop sending batches for a request.

2) Verify that the files app does send onAbortRequested in the cases we would expect. For example if the user navigates quickly down two levels of directories with a lot of files that it aborts the request for the files in the first directory.

Currently the plugin is just a FIFO queue and navigating down very big structure with a lot of files means that the request you actually care about is way at the end and starts giving timeout messages before it even starts.

illiminable commented 5 years ago

Closing old bugs.

Since Chrome 71, SMB is now natively supported by Chrome OS and this Chrome extension/app is deprecated. The new implementation is an order magnitude or two faster and much more reliable.

On Chrome 71 or higher you can:

Open the files app Click the "three dot menu" in the top right Choose "Add New Service" Choose "SMB file share"

A dialog in settings will open (in 72 and later it's a standalone dialog). Enter your share information as before.

You can uninstall the chrome app as it will be deprecated in the near future.

If you have bugs with the new implementation you can open them at crbug.com under component "Platform>Apps>FileManager"