search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[JS-to-C++ tests] Refactor PC/SC test sources #1087

Closed emaxx-google closed 9 months ago

emaxx-google commented 9 months ago

Similarly to https://github.com/GoogleChromeLabs/chromeos_smart_card_connector/pull/1077, refactor pcsc-api-jstocxxtest.js to group test cases together into constant variables, to make the deeply nested structure of tests easier to follow.

This is a pure refactoring change.

emaxx-google commented 9 months ago

Commit#1 just moved pieces of text around, and commit#2 applied clang-format. The diff is still ugly, but maybe that separation helps a tiny bit.

github-actions[bot] commented 9 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 72.38% lines.