search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[PC/SC test] Avoid deadlock in sim interrupt xfs #1106

Closed emaxx-google closed 6 months ago

emaxx-google commented 8 months ago

Move interrupt transfer replies in testing_smart_card_simulation outside of the mutex.

This is needed for follow-ups that rework how our Libusb port handles incoming requests, because the new implementation may synchronously start a new USB API call when receiving the previous call's result. Without the current change, this would deadlock in the unit tests.

This change contributes to #1104.

github-actions[bot] commented 8 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.18% lines.

github-actions[bot] commented 6 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.24% lines.