search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
134 stars 49 forks source link

[JS-to-C++ tests] Bulletproof teardowns #1123

Closed emaxx-google closed 8 months ago

emaxx-google commented 8 months ago

Make the code in test cases' tearDown functions resistant to failures in setUps. This avoids spurious errors like "reading the dispose property of a null object" after the real test failures.

This commit is a no-op for the successfully built tree, it's only intended to improve troubleshooting of test failures.

github-actions[bot] commented 8 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.32% lines.

github-actions[bot] commented 8 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.29% lines.

emaxx-google commented 8 months ago

OK, I had to fix the suggestion, so that the code compiles.

Thanks for the review.