GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

Re-enable `INCOMING_MODULE_JS_API` in WebAssembly builds #1124

Open emaxx-google opened 5 months ago

emaxx-google commented 5 months ago

Emscripten's INCOMING_MODULE_JS_API parameter has been broken: see https://github.com/emscripten-core/emscripten/issues/21167. It became even more broken in recent versions, causing runtime breakages in our code: https://github.com/emscripten-core/emscripten/issues/20457. To unblock our upreving to the recent Emscripten versions, we should temporarily stop using INCOMING_MODULE_JS_API.

However once the quoted Emscripten issues get resolved, we should re-enable INCOMING_MODULE_JS_API back as it brings noticeable output size reduction.