GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[wasm] Temporarily disable INCOMING_MODULE_JS_API #1125

Closed emaxx-google closed 5 months ago

emaxx-google commented 5 months ago

This flag is broken in recent Emscripten versions: see https://github.com/emscripten-core/emscripten/issues/21167 and https://github.com/emscripten-core/emscripten/issues/20457.

Stop using it until it gets fixed in Emscripten (tracking issue #1124).

We used this flag as a pure optimization, to it's not critical to have it enabled now.

github-actions[bot] commented 5 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.28% lines.

github-actions[bot] commented 5 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.25% lines.