search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

Popup dialogs are created with wrong width #1126

Closed emaxx-google closed 5 months ago

emaxx-google commented 5 months ago

When a dialog (e.g., the built-in PIN dialog in example_cpp_smart_card_client_app) is opened, it gets a wrong width instead of the one specified in the code.

emaxx-google commented 5 months ago

I think it regressed in #518: this line shouldn't have been deleted:

Object.assign(createWindowOptions, opt_createWindowOptionsOverrides);
emaxx-google commented 5 months ago

And there's another issue introduced in #404, when the format of the "width"/"height" parameters has changed, but the example PIN dialog callsites weren't updated accordingly.