[ui] Fix options passing in runModalDialog

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS

https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco

Apache License 2.0

133 stars 50 forks source link

[ui] Fix options passing in runModalDialog #1127

Closed emaxx-google closed 5 months ago

emaxx-google commented 5 months ago

Fix the PopupOpener.runModalDialog() function to correctly pass the optional window parameters.

They were ignored (this regressed in #518). One noticeable example was incorrect width of the PIN prompt in the example applications. Tracking issue #1126.

github-actions[bot] commented 5 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.32% lines.