GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[mv3] Use globalThis instead of window #1130

Closed emaxx-google closed 5 months ago

emaxx-google commented 5 months ago

Switch a couple of places that use the "window" object to use "globalThis" instead. The latter is a better equivalent because it works in Manifest V3 Service Workers as well (in a Service Worker, "self" should be used instead of "window"; "globalThis" is an alias to either of those).

This contributes to the effort tracked by #1129.

github-actions[bot] commented 5 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.36% lines.

emaxx-google commented 5 months ago

Thanks for the reviews!