search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
134 stars 49 forks source link

Resolve permissions check when managed policy gets updated #1134

Closed annklr closed 6 months ago

annklr commented 7 months ago

A permissions prompting dialog should be automatically closed and the permissions check resolved if the managed storage gets updated with the relevant policy value while waiting for a response from the user.

emaxx-google commented 7 months ago

There are linter errors: https://github.com/GoogleChromeLabs/chromeos_smart_card_connector/actions/runs/8021684961/job/21914319317?pr=1134

emaxx-google commented 7 months ago

Thanks for the fix. I'll try to do the detailed review till the end of the day.

annklr commented 6 months ago

Thank you for the review! I added the test cases in a new file policy-or-prompting-permissions-checker-unittest.js because I believe they do require the PolicyOrPromptingPermissionsChecker and rely on both the managed registry and user prompting checker. Let me know, if I should move them.