search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[mv3] Skip BackgroundPageUnloadPreventing #1137

Closed emaxx-google closed 3 months ago

emaxx-google commented 3 months ago

Skip executing the "BackgroundPageUnloadPreventing" code when built in the "extension" packaging mode.

This code doesn't work under extensions manifest v3, because DOM operations aren't available for Service Workers. We also don't need this code because Chrome will itself keep the application alive (based on the open USB communication and/or message channels to other extensions).

emaxx-google commented 3 months ago

Also updated the related comment in the example client sources.

github-actions[bot] commented 3 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.35% lines.

github-actions[bot] commented 3 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.36% lines.

github-actions[bot] commented 3 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.38% lines.

emaxx-google commented 3 months ago

I've updated the PR to also skip packaging the now-unnecessary files (background-page-unload-preventing-iframe.js and background-page-unload-preventing-iframe.html) in the corresponding configuration.

github-actions[bot] commented 3 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.35% lines.